Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Tag ParticleFilters.jl v0.3.0 #19226

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

attobot
Copy link
Contributor

@attobot attobot commented Oct 31, 2018

Repository: JuliaPOMDP/ParticleFilters.jl
Release: v0.3.0
Travis: Travis Build Status
Diff: vs v0.2.0
requires vs v0.2.0:

--- 0.2.0/requires
+++ 0.3.0/requires
@@ -1,4 +1,4 @@
-julia 0.6
+julia 0.7
 StatsBase
 POMDPs 0.6
 POMDPModelTools

cc: @zsunberg

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@zsunberg
Copy link
Contributor

Seems like the failure in the JuliaCIBot tests is because imagemagick is missing. Is that ok, or is there a workaround to make it skip those tests somehow? It does pass on Travis: https://travis-ci.org/JuliaPOMDP/ParticleFilters.jl/builds/448661677

@andreasnoack
Copy link
Member

It looks like it is a regression from the previous version. Any idea why this would happen?

@zsunberg
Copy link
Contributor

zsunberg commented Nov 1, 2018

The new tests include a tutorial that produces a gif using imagemagick through Reel.jl. The old tests didn't include this tutorial.

I'd like to keep the tutorial in the tests if possible. I guess ideally Reel.jl would make sure imagemagick is provided. Is there any way to have certain tests run on Travis, but not on JuliaCI?

@andreasnoack
Copy link
Member

It looks like that test is simply skipped on Travis, see https://travis-ci.org/JuliaPOMDP/ParticleFilters.jl/jobs/448661679#L1591. There are quite a few errors on Travis but for some reason, they don't seem to be fatal.

If theory, you'd be able to skip some of the tests with something if !(get("ENV", "TRAVIS_CI", "false") == "true") && (get(ENV, "CI", "false") == "true") but I think it would be better to figure out if we can get this working first. Maybe adding ImageMagick.jl as test dependency is an option.

@attobot
Copy link
Contributor Author

attobot commented Nov 1, 2018

Repository: JuliaPOMDP/ParticleFilters.jl
Release: v0.3.0
Travis: Travis Build Status
Diff: vs v0.2.0
requires vs v0.2.0:

--- 0.2.0/requires
+++ 0.3.0/requires
@@ -1,4 +1,4 @@
-julia 0.6
+julia 0.7
 StatsBase
 POMDPs 0.6
 POMDPModelTools

cc: @zsunberg

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@attobot
Copy link
Contributor Author

attobot commented Nov 1, 2018

Repository: JuliaPOMDP/ParticleFilters.jl
Release: v0.3.0
Travis: Travis Build Status
Diff: vs v0.2.0
requires vs v0.2.0:

--- 0.2.0/requires
+++ 0.3.0/requires
@@ -1,4 +1,4 @@
-julia 0.6
+julia 0.7
 StatsBase
 POMDPs 0.6
 POMDPModelTools

cc: @zsunberg

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@attobot attobot force-pushed the ParticleFilters/v0.3.0 branch from 67a3558 to 863de05 Compare November 1, 2018 22:13
@andreasnoack andreasnoack merged commit bb8093c into JuliaLang:metadata-v2 Nov 2, 2018
@attobot attobot deleted the ParticleFilters/v0.3.0 branch November 2, 2018 00:01
@zsunberg
Copy link
Contributor

zsunberg commented Nov 2, 2018

@andreasnoack thanks for the feedback. I share your desire for it to work, but I think the solution is to get Reel.jl fixed to make sure imagemagick is available shashi/Reel.jl#15.

So for now I just disabled running those notebook tutorials on Julia CI

@zsunberg
Copy link
Contributor

zsunberg commented Nov 2, 2018

oh, I see you merged it, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants